On Fri, Feb 22, 2019 at 11:04 AM Bartosz Golaszewski <[email protected]> wrote: > > czw., 21 lut 2019 o 20:56 Andy Shevchenko <[email protected]> > napisał(a): > > > > On Thu, Feb 21, 2019 at 9:55 PM Andy Shevchenko > > <[email protected]> wrote: > > > > > > On Thu, Feb 21, 2019 at 6:27 PM Bartosz Golaszewski <[email protected]> wrote: > > > > > > > > From: Bartosz Golaszewski <[email protected]> > > > > > > > > We only build devm_ioremap_resource() if HAS_IOMEM is selected, so this > > > > dependency must cascade down to devm_platform_ioremap_resource(). > > > > > > > +#ifdef CONFIG_HAS_IOMEM > > > > void __iomem *devm_platform_ioremap_resource(struct platform_device > > > > *pdev, > > > > unsigned int index) > > > > { > > > > @@ -96,6 +97,7 @@ void __iomem *devm_platform_ioremap_resource(struct > > > > platform_device *pdev, > > > > return devm_ioremap_resource(&pdev->dev, res); > > > > } > > > > EXPORT_SYMBOL_GPL(devm_platform_ioremap_resource); > > > > +#endif /* CONFIG_HAS_IOMEM */ > > > > > > What about declaration in *.h? > > > > > > Perhaps you may just do this inside the function? > > > > #ifdef ... > > #else > > return ERR_PTR(-ENOTSUPP); > > #endif > > > > I followed the example of devm_ioremap_resource() which doesn't do > this - it just expects never to be used by systems without IOMEM.
Okay, that's fine! -- With Best Regards, Andy Shevchenko
