On Fri, 22 Feb 2019 10:10:20 +0100 Juerg Haefliger <[email protected]> wrote:
> echo -e is not POSIX. Depending on what /bin/sh is, we can get > incorrect output like: > $ -e -n [1] Basic trace file check > $ -e [PASS] > > Fix that by using printf instead. > > Signed-off-by: Juerg Haefliger <[email protected]> Looks good to me. Acked-by: Masami Hiramatsu <[email protected]> Thanks! > --- > tools/testing/selftests/ftrace/ftracetest | 9 +++++++-- > 1 file changed, 7 insertions(+), 2 deletions(-) > > diff --git a/tools/testing/selftests/ftrace/ftracetest > b/tools/testing/selftests/ftrace/ftracetest > index fc755e1b50f1..20c9c0ad8682 100755 > --- a/tools/testing/selftests/ftrace/ftracetest > +++ b/tools/testing/selftests/ftrace/ftracetest > @@ -173,8 +173,13 @@ strip_esc() { > } > > prlog() { # messages > - echo -e "$@" > - [ "$LOG_FILE" ] && echo -e "$@" | strip_esc >> $LOG_FILE > + newline="\n" > + if [ "$1" = "-n" ] ; then > + newline= > + shift > + fi > + printf "$*$newline" > + [ "$LOG_FILE" ] && printf "$*$newline" | strip_esc >> $LOG_FILE > } > catlog() { #file > cat $1 > -- > 2.19.1 > -- Masami Hiramatsu <[email protected]>
