Hi Pingfan,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on linus/master]
[also build test ERROR on v5.0-rc4]
[cannot apply to next-20190222]
[if your patch is applied to the wrong git tree, please drop us a note to help 
improve the system]

url:    
https://github.com/0day-ci/linux/commits/Pingfan-Liu/mm-numa-extract-the-code-of-building-node-fall-back-list/20190225-143613
config: i386-randconfig-a1-201908 (attached as .config)
compiler: gcc-4.9 (Debian 4.9.4-2) 4.9.4
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

All errors (new ones prefixed by >>):

   ld: mm/memblock.o: in function `memblock_build_node_order':
>> mm/memblock.c:1364: undefined reference to `build_node_order'

vim +1364 mm/memblock.c

  1342  
  1343  /*
  1344   * build_node_order() relies on cpumask_of_node(), hence arch should 
set up
  1345   * cpumask before calling this func.
  1346   */
  1347  void __init memblock_build_node_order(void)
  1348  {
  1349          int nid, i;
  1350          nodemask_t used_mask;
  1351  
  1352          node_fallback = memblock_alloc(MAX_NUMNODES * sizeof(int *),
  1353                  sizeof(int *));
  1354          for_each_online_node(nid) {
  1355                  node_fallback[nid] = memblock_alloc(
  1356                          num_online_nodes() * sizeof(int), sizeof(int));
  1357                  for (i = 0; i < num_online_nodes(); i++)
  1358                          node_fallback[nid][i] = NUMA_NO_NODE;
  1359          }
  1360  
  1361          for_each_online_node(nid) {
  1362                  nodes_clear(used_mask);
  1363                  node_set(nid, used_mask);
> 1364                  build_node_order(node_fallback[nid], num_online_nodes(),
  1365                          nid, &used_mask);
  1366          }
  1367  }
  1368  

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: application/gzip

Reply via email to