Hi all, Friendly ping:
Who can review or take this, please? Thanks -- Gustavo On 2/12/19 11:50 AM, Gustavo A. R. Silva wrote: > n preparation to enabling -Wimplicit-fallthrough, mark switch > cases where we are expecting to fall through. > > This patch fixes the following warning: > > drivers/rapidio/devices/rio_mport_cdev.c: In function ‘mport_release_mapping’: > drivers/rapidio/devices/rio_mport_cdev.c:2151:3: warning: this statement may > fall through [-Wimplicit-fallthrough=] > rio_unmap_inb_region(mport, map->phys_addr); > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > CC drivers/regulator/fixed-helper.o > CC drivers/pinctrl/stm32/pinctrl-stm32f429.o > drivers/rapidio/devices/rio_mport_cdev.c:2152:2: note: here > case MAP_DMA: > ^~~~ > > Warning level 3 was used: -Wimplicit-fallthrough=3 > > This patch is part of the ongoing efforts to enable > -Wimplicit-fallthrough. > > Signed-off-by: Gustavo A. R. Silva <[email protected]> > --- > drivers/rapidio/devices/rio_mport_cdev.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/rapidio/devices/rio_mport_cdev.c > b/drivers/rapidio/devices/rio_mport_cdev.c > index cbe467ff1aba..1e1f42e210a0 100644 > --- a/drivers/rapidio/devices/rio_mport_cdev.c > +++ b/drivers/rapidio/devices/rio_mport_cdev.c > @@ -2149,6 +2149,7 @@ static void mport_release_mapping(struct kref *ref) > switch (map->dir) { > case MAP_INBOUND: > rio_unmap_inb_region(mport, map->phys_addr); > + /* fall through */ > case MAP_DMA: > dma_free_coherent(mport->dev.parent, map->size, > map->virt_addr, map->phys_addr); >
