> -----Original Message----- > From: Andrew Donnellan <[email protected]> > Sent: Wednesday, 27 February 2019 6:16 PM > To: Alastair D'Silva <[email protected]>; [email protected] > Cc: Greg Kurz <[email protected]>; Frederic Barrat <[email protected]>; > Arnd Bergmann <[email protected]>; Greg Kroah-Hartman > <[email protected]>; [email protected]; linux- > [email protected] > Subject: Re: [PATCH 1/5] ocxl: Rename struct link to ocxl_link > > On 27/2/19 3:57 pm, Alastair D'Silva wrote: > > From: Alastair D'Silva <[email protected]> > > > > The term 'link' is ambiguous (especially when the struct is used for a > > list), so rename it for clarity. > > > > Signed-off-by: Alastair D'Silva <[email protected]> > > Reviewed-by: Greg Kurz <[email protected]> > > --- > > drivers/misc/ocxl/file.c | 2 +- > > drivers/misc/ocxl/link.c | 36 ++++++++++++++++++------------------ > > 2 files changed, 19 insertions(+), 19 deletions(-) > > > > diff --git a/drivers/misc/ocxl/file.c b/drivers/misc/ocxl/file.c index > > e6a607488f8a..16eb8a60d5c7 100644 > > --- a/drivers/misc/ocxl/file.c > > +++ b/drivers/misc/ocxl/file.c > > @@ -152,7 +152,7 @@ static long afu_ioctl_enable_p9_wait(struct > > ocxl_context *ctx, > > > > if (status == ATTACHED) { > > int rc; > > - struct link *link = ctx->afu->fn->link; > > + void *link = ctx->afu->fn->link; > > This doesn't look like a rename...
That corrects the type to what the member (and prototype for ocxl_link_update_pe) declare it as. The struct link there is bogus, it shouldn't even compile (since the intended struct link is defined in a different compilation unit), but instead picks up a different definition of 'struct link' from elsewhere. -- Alastair D'Silva mob: 0423 762 819 skype: alastair_dsilva msn: [email protected] blog: http://alastair.d-silva.org Twitter: @EvilDeece
