On Thu, Feb 28, 2019 at 06:51:14PM +0100, Peter Zijlstra wrote: > On Thu, Feb 28, 2019 at 08:49:57AM -0800, Linus Torvalds wrote: > > Yes, it is redundant (but harmlessly so) if no fault occurs. > > Oooh, there's a label hidden in unsafe_put_user()... > > And yes, objtool seems to miss that, damn. I'll go stare at that.
Weird, that jump is from C, not from a .fixup table. objtool _should_ see that and complain if there is a AC=1 path that reaches RET. AFAIU validate_branch() should recurse down every single branch, right Josh?
