On 28.02.2019 21:46, Arnaldo Carvalho de Melo wrote:
> Em Thu, Feb 28, 2019 at 11:59:01AM +0300, Alexey Budankov escreveu:
>> +++ b/tools/build/Makefile.feature
>> @@ -66,7 +66,8 @@ FEATURE_TESTS_BASIC := \
>> sched_getcpu \
>> sdt \
>> setns \
>> - libaio
>> + libaio \
>> + libzstd
>
> Since you added this as a basic feature to test, add this when you
> resubmit, so that 'perf -vv' tells us that this basic feature is indeed
> present.
Yes, will do. Actually came to similar idea when
observed your test report in pull requests:
# perf version --build-options
perf version 5.0.rc5.gde667c
dwarf: [ on ] # HAVE_DWARF_SUPPORT
dwarf_getlocations: [ on ] # HAVE_DWARF_GETLOCATIONS_SUPPORT
glibc: [ on ] # HAVE_GLIBC_SUPPORT
gtk2: [ on ] # HAVE_GTK2_SUPPORT
syscall_table: [ on ] # HAVE_SYSCALL_TABLE_SUPPORT
libbfd: [ on ] # HAVE_LIBBFD_SUPPORT
libelf: [ on ] # HAVE_LIBELF_SUPPORT
libnuma: [ on ] # HAVE_LIBNUMA_SUPPORT
numa_num_possible_cpus: [ on ] # HAVE_LIBNUMA_SUPPORT
libperl: [ on ] # HAVE_LIBPERL_SUPPORT
libpython: [ on ] # HAVE_LIBPYTHON_SUPPORT
libslang: [ on ] # HAVE_SLANG_SUPPORT
libcrypto: [ on ] # HAVE_LIBCRYPTO_SUPPORT
libunwind: [ on ] # HAVE_LIBUNWIND_SUPPORT
libdw-dwarf-unwind: [ on ] # HAVE_DWARF_SUPPORT
zlib: [ on ] # HAVE_ZLIB_SUPPORT
lzma: [ on ] # HAVE_LZMA_SUPPORT
get_cpuid: [ on ] # HAVE_AUXTRACE_SUPPORT
bpf: [ on ] # HAVE_LIBBPF_SUPPORT
and it misses HAVE_ZSTD_SUPPORT define.
Thanks,
Alexey
>
>
> diff --git a/tools/perf/builtin-version.c b/tools/perf/builtin-version.c
> index 50df168be326..d41197fc8cef 100644
> --- a/tools/perf/builtin-version.c
> +++ b/tools/perf/builtin-version.c
> @@ -78,6 +78,7 @@ static void library_status(void)
> STATUS(HAVE_LZMA_SUPPORT, lzma);
> STATUS(HAVE_AUXTRACE_SUPPORT, get_cpuid);
> STATUS(HAVE_LIBBPF_SUPPORT, bpf);
> + STATUS(HAVE_ZSTD_SUPPORT, bpf);
> }
>
> int cmd_version(int argc, const char **argv)
>
