On 3/4/19 2:57 AM, Axel Lin wrote:
> selector 0xB (1011) should be 2.6V rather than 2.7V, fit ix.
>
> Table 5-4. LDOA1 Output Voltage Options
> VID Bits VOUT VID Bits VOUT VID Bits VOUT VID Bits VOUT
> 0000 1.35 0100 1.8 1000 2.3 1100 2.85
> 0001 1.5 0101 1.9 1001 2.4 1101 3.0
> 0010 1.6 0110 2.0 1010 2.5 1110 3.3
> 0011 1.7 0111 2.1 1011 2.6 1111 Not Used
>
> Fixes: d2a2e729a666 ("regulator: tps65086: Add regulator driver for the
> TPS65086 PMIC")
> Signed-off-by: Axel Lin <[email protected]>
> ---
> Hi Steven and Andrew,
> I don't have this h/w to test. Can you help to verify it?
>
I'll dig one of these out for testing, I'll report back here if
something is wrong, but for now you are correct according to the
datasheet so:
Acked-by: Andrew F. Davis <[email protected]>
> Thanks,
> Axel
>
> drivers/regulator/tps65086-regulator.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/regulator/tps65086-regulator.c
> b/drivers/regulator/tps65086-regulator.c
> index 45e96e154690..5a5e9b5bf4be 100644
> --- a/drivers/regulator/tps65086-regulator.c
> +++ b/drivers/regulator/tps65086-regulator.c
> @@ -90,8 +90,8 @@ static const struct regulator_linear_range
> tps65086_buck345_25mv_ranges[] = {
> static const struct regulator_linear_range tps65086_ldoa1_ranges[] = {
> REGULATOR_LINEAR_RANGE(1350000, 0x0, 0x0, 0),
> REGULATOR_LINEAR_RANGE(1500000, 0x1, 0x7, 100000),
> - REGULATOR_LINEAR_RANGE(2300000, 0x8, 0xA, 100000),
> - REGULATOR_LINEAR_RANGE(2700000, 0xB, 0xD, 150000),
> + REGULATOR_LINEAR_RANGE(2300000, 0x8, 0xB, 100000),
> + REGULATOR_LINEAR_RANGE(2850000, 0xC, 0xD, 150000),
> REGULATOR_LINEAR_RANGE(3300000, 0xE, 0xE, 0),
> };
>
>
