On Mon, 04 Mar 2019 20:02:18 +0000,
Arnd Bergmann <a...@arndb.de> wrote:
>
> gcc points out that irqs_num is not initialized when of_property_read_u32()
> is an empty stub function:
>
> Included from drivers/irqchip/irq-imx-irqsteer.c:7:
> drivers/irqchip/irq-imx-irqsteer.c: In function 'imx_irqsteer_probe':
> include/uapi/linux/kernel.h:13:49: error: 'irqs_num' may be used
> uninitialized in this function [-Werror=maybe-uninitialized]
>
> The same can actually happen with CONFIG_OF=y as well, though we don't
> get a warning then.
>
> Add error checking here that lets the code deal with missing or
> invalid properties as well as avoid the warning.
>
> Fixes: 28528fca4908 ("irqchip/imx-irqsteer: Add multi output interrupts
> support")
> Signed-off-by: Arnd Bergmann <a...@arndb.de>
> ---
> drivers/irqchip/irq-imx-irqsteer.c | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
Applied, thanks Arnd.
M.
--
Jazz is not dead, it just smell funny.
