On 3/4/19 4:24 PM, Enrico Weigelt, metux IT consult wrote:
> pcengines-apuv2 board driver needs to explicitly select LEDS_CLASS,
> INPUT, INPUT_KEYBOARD, so these are automatically defined correctly
> (eg. LEDS_CLASS=y if PCENGINES_APU2=y)
>
> Cc: [email protected]
> Cc: [email protected]
> Cc: [email protected]
> Cc: [email protected]
> Cc: [email protected]
> Reported-by: kbuild test robot <[email protected]>
> Reported-by: [email protected]
> Reported-by: [email protected]
> Signed-off-by: Enrico Weigelt, metux IT consult <[email protected]>
> ---
> drivers/platform/x86/Kconfig | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
> index 851ea92..7d53380 100644
> --- a/drivers/platform/x86/Kconfig
> +++ b/drivers/platform/x86/Kconfig
> @@ -1307,7 +1307,10 @@ config PCENGINES_APU2
> tristate "PC Engines APUv2/3 front button and LEDs driver"
> select GPIO_AMD_FCH
> select KEYBOARD_GPIO_POLLED
> + select LEDS_CLASS
> select LEDS_GPIO
> + select INPUT
Nak. We don't select entire subsystems. You should do:
depends on INPUT
select INPUT_KEYBOARD
> + select INPUT_KEYBOARD
> help
> This driver provides support for the front button and LEDs on
> PC Engines APUv2/APUv3 board.
>
--
~Randy
