On Fri, Aug 10, 2007 at 12:40:49PM -0400, [EMAIL PROTECTED] wrote: > On Fri, 10 Aug 2007 11:23:34 +0200, Aurelien Jarno said: > > I have just tried it, and it fails to build for MIPS with the following > > error: > > > > CC arch/mips/kernel/asm-offsets.s > > In file included from include/linux/sched.h:58, > > from arch/mips/kernel/asm-offsets.c:13: > > include/linux/mm_types.h:115: error: expected specifier-qualifier-list > > before 'pgprot_t' > > include/linux/mm_types.h:169: warning: 'struct file' declared inside > > parameter list > > include/linux/mm_types.h:169: warning: its scope is only this definition or > > declaration, which is probably not what you want > > include/linux/mm_types.h:175: error: expected specifier-qualifier-list > > before 'pgd_t' > > > > > > The trivial patch below fixes this problem. > > Rather than adding it to an include/linux file, where it then gets dragged > in on *all* architectures, maybe we should investigate why it dies on MIPS, > and fix it for *that* arch?
It must be included on *all* architectures, and the architectures where asm/page.h wasn't by chance already included indirectly included by some other header don't compile. cu Adrian -- "Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/