On Thu, 7 Mar 2019 09:19:55 +1300 Brodie Greenfield <brodie.greenfi...@alliedtelesis.co.nz> wrote:
> +ip_mr_cache_queue_length - INTEGER > + Limit the number of multicast packets we can have in the queue to be > + resolved. > + Bear in mind that when an unresolved multicast packet is received, > + there is an O(n) traversal of the queue. This should be considered > + if increasing. > + Why not make it to a unsigned value? A negative value doesn't make much sense here. Although other sysctl values date back to a time when Linux was sloppy about allowing negative values, it would be good to use unsigned now.