Nathan Chancellor <[email protected]> writes: > On Thu, Mar 07, 2019 at 11:09:19AM +0100, Arnd Bergmann wrote: >> clang points out several instances of mismatched types in this drivers, >> all coming from a single declaration: >> >> drivers/mmc/host/pxamci.c:193:15: error: implicit conversion from >> enumeration type 'enum dma_transfer_direction' to >> different enumeration type 'enum dma_data_direction' >> [-Werror,-Wenum-conversion] >> direction = DMA_DEV_TO_MEM; >> ~ ^~~~~~~~~~~~~~ >> drivers/mmc/host/pxamci.c:212:62: error: implicit conversion from >> enumeration type 'enum dma_data_direction' to >> different enumeration type 'enum dma_transfer_direction' >> [-Werror,-Wenum-conversion] >> tx = dmaengine_prep_slave_sg(chan, data->sg, host->dma_len, >> direction, >> >> The behavior is correct, so this must be a simply typo from >> dma_data_direction and dma_transfer_direction being similarly named >> types with a similar purpose. >> >> Fixes: 6464b7140951 ("mmc: pxamci: switch over to dmaengine use") >> Signed-off-by: Arnd Bergmann <[email protected]> > > Reviewed-by: Nathan Chancellor <[email protected]> Acked-by: Robert Jarzmik <[email protected]>
Cheers. -- Robert
