+ device tree folks On Thu, Mar 07, 2019 at 05:46:50PM +0530, Harish Bandi wrote: > This patch series we add support for wcn3998 BT chip set. This new chipset > is based from the wcn3990 with minimal power numbers. So here in this patch > The major difference between wcn3990 and wcn3998 is only power numbers. where > as init process and fw download is same with wcn3990.So we are leveraging the > existing code of wcn3990 along with readiing the voltages from the dts file.
About how many different variants are we talking? Couldn't you just use a different compatible string for each variant and specify the voltage/current limits in the hci_qca.c driver, as currently done for the WCN3990? I understand that it requires touching the driver for each new variant, but it might be preferable to specify these static values in a single location, instead of repeating them in the DT snippets of every device that uses such a controller, with the possiblity of configuration errors. The DT folks can probably provide guidance on what is typically done in cases like this. Thanks Matthias
