Sorry, a few things I thought of after sending the Reviewed-by email... > + v3d->reset = devm_reset_control_get_exclusive(dev, NULL); > + if (IS_ERR(v3d->reset)) { > + ret = PTR_ERR(v3d->reset); > + > + if (ret == -EPROBE_DEFER) > + goto dev_free; Might be preferable to make this explicitly check against the not-found error code (whatever that is)? As in if (not found) <fallback to bridge> else <return error code>. Similarly...
> + if (platform_get_irq(v3d->pdev, 1) < 0) { This should probably explicitly check for not-found rather than any error. As-is, we might silently go down the single-interrupt-line path on a platform with 2 interrupt lines if platform_get_irq(v3d->pdev, 1) hits some other error. > + ret = devm_request_irq(v3d->dev, platform_get_irq(v3d->pdev, > 0), > + v3d_hub_irq, IRQF_SHARED, > + "v3d_hub", v3d); > + ret = devm_request_irq(v3d->dev, platform_get_irq(v3d->pdev, > 1), > + v3d_irq, IRQF_SHARED, > + "v3d_core0", v3d); Not introduced by this change, but return value from first devm_request_irq ignored here?