On Mon 2019-01-07 20:05:55, Pavel Machek wrote: > Hi! > > Can we do something with that code? > > First -- tables should not be necceessary. Formula for li-ion open > circuit voltage is well-known, and does not really depend on the > device -- only on the chemistry of battery. > > state of charge = f( voltage, current, internal resistance ) > > (And yes, internal resistance depends on temperature and health of the > battery). > > Second, even if we need tables, why is it doing multiple allocations? > > info->ocv_temp[index] = -EINVAL; > > That's just wrong. Ocv_temp is temperature in celsius. Temperatures go > below zero.
Ping? That code is just bad. Does someone care?
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures)
http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
signature.asc
Description: Digital signature
