On 3/12/19 8:01 AM, Steven Rostedt wrote: > On Tue, 12 Mar 2019 04:58:32 -0400 > "Valdis Klētnieks" <valdis.kletni...@vt.edu> wrote: > >> CC kernel/trace/trace_kprobe.o >> kernel/trace/trace_kprobe.c:41: warning: cannot understand function >> prototype: 'struct trace_kprobe ' >> >> The real problem is that a comment looked like kerneldoc when it shouldn't >> be... >> >> Signed-off-by: Valdis Kletnieks <valdis.kletni...@vt.edu> >> >> diff --git a/kernel/trace/trace_kprobe.c b/kernel/trace/trace_kprobe.c >> index 9eaf07f99212..c825c591553a 100644 >> --- a/kernel/trace/trace_kprobe.c >> +++ b/kernel/trace/trace_kprobe.c >> @@ -35,7 +35,7 @@ static struct dyn_event_operations trace_kprobe_ops = { >> .match = trace_kprobe_match, >> }; >> >> -/** >> +/* > > NACK. > > This isn't a kernel doc comment, and I don't want to make it one when > it is not. Just ignore that warning. > > -- Steve
Huh? The patch doesn't do that -- it does the opposite of that. I.e., begin a non-kernel-doc comment with /* instead of /**. > >> * Kprobe event core functions >> */ >> struct trace_kprobe { > -- ~Randy