Andy Shevchenko <andy.shevche...@gmail.com> writes: > On Fri, Mar 1, 2019 at 9:14 PM Mans Rullgard <m...@mansr.com> wrote: >> >> The charlcd driver currently flashes the backlight once on init. >> This may not be desirable. Thus, add options for turning the >> backlight off or on as well. >> >> Signed-off-by: Mans Rullgard <m...@mansr.com> >> --- >> drivers/auxdisplay/Kconfig | 21 +++++++++++++++++++++ >> drivers/auxdisplay/charlcd.c | 10 +++++++++- >> 2 files changed, 30 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/auxdisplay/Kconfig b/drivers/auxdisplay/Kconfig >> index 7d3fe27d6868..c52c738e554a 100644 >> --- a/drivers/auxdisplay/Kconfig >> +++ b/drivers/auxdisplay/Kconfig >> @@ -445,6 +445,27 @@ config PANEL_BOOT_MESSAGE >> An empty message will only clear the display at driver init time. >> Any other >> printf()-formatted message is valid with newline and escape codes. >> >> +choice >> + prompt "Backlight initial state" >> + default CHARLCD_BL_FLASH > > LGTM, but I don't agree on this default. I would prefer either on or > off, not flashing for sure. > Though it seems the case before the patch...
The current code unconditionally flashes the light once. I though it best to keep that behaviour as default, even if it's not seen as ideal. -- Måns Rullgård
