Mathieu, On 3/13/19 3:28 PM, Mathieu Malaterre wrote: > ping ? >
I have sent the following patch to address all these warnings in firewire: https://lore.kernel.org/patchwork/patch/1040737/ and, as this is being ignored, I'll add it to my tree for 5.2. Thanks -- Gustavo > On Mon, Jan 14, 2019 at 9:42 PM Mathieu Malaterre <ma...@debian.org> wrote: >> >> There is a plan to build the kernel with -Wimplicit-fallthrough and >> this place in the code produced a warning (W=1). >> >> In this particular case rewrote the comment to start with the string "fall >> through", so as to match the regular expression expected by GCC. >> >> This commit remove the following warning: >> >> drivers/firewire/core-iso.c:308:7: warning: this statement may fall >> through [-Wimplicit-fallthrough=] >> >> Signed-off-by: Mathieu Malaterre <ma...@debian.org> >> --- >> drivers/firewire/core-iso.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/firewire/core-iso.c b/drivers/firewire/core-iso.c >> index 35e784cffc23..d2d50bda5a5f 100644 >> --- a/drivers/firewire/core-iso.c >> +++ b/drivers/firewire/core-iso.c >> @@ -308,7 +308,7 @@ static int manage_channel(struct fw_card *card, int >> irm_id, int generation, >> if ((data[0] & bit) == (data[1] & bit)) >> continue; >> >> - /* 1394-1995 IRM, fall through to retry. */ >> + /* fall through - 1394-1995 IRM to retry. */ >> default: >> if (retry) { >> retry--; >> -- >> 2.19.2 >>
