On 3/13/19 3:34 PM, Jason A. Donenfeld wrote: > Conceptually this seems pretty reasonable. Though, style-wise, perhaps > you might want to put those breaks on the next line too, i.e. s/; > break;/;\n\t\tbreak;/? > I agree. With that, you can add my: Acked-by: Gustavo A. R. Silva <gust...@embeddedor.com> Thanks -- Gustavo
- [PATCH v2] lib/siphash.c: annotate implicit fall throu... Mathieu Malaterre
- Re: [PATCH v2] lib/siphash.c: annotate implicit f... Jason A. Donenfeld
- Re: [PATCH v2] lib/siphash.c: annotate implic... Gustavo A. R. Silva
- Re: [PATCH v2] lib/siphash.c: annotate implic... Mathieu Malaterre