On Sun, Mar 17, 2019 at 12:34:24AM +0800, Jin Yao wrote: > The 'percore' event qualifier which sums up the event counts for both > hardware threads in a core. For example, > > perf stat -e cpu/event=0,umask=0x3,percore=1/,cpu/event=0,umask=0x3/ > > In this example, we count the event 'ref-cycles' per-core and per-CPU in > one perf stat command-line. > > We can already support per-core counting with --per-core, but it's > often useful to do this together with other metrics that are collected > per CPU (per hardware thread). So this patch series supports this > per-core counting on a event level. > > v2: > --- > 1. Change 'coresum' to 'percore'. > 2. Move the aggregate counts printing to a seperate patch.
other than the nit for patch 1, it all looks ok to me Acked-by: Jiri Olsa <jo...@kernel.org> thanks, jirka > > Jin Yao (4): > perf: Add a 'percore' event qualifier > perf stat: Factor out aggregate counts printing > perf stat: Support 'percore' event qualifier > perf test: Add a simple test for term 'percore' > > tools/perf/Documentation/perf-stat.txt | 4 ++ > tools/perf/builtin-stat.c | 21 +++++++ > tools/perf/tests/parse-events.c | 10 ++- > tools/perf/util/evsel.c | 2 + > tools/perf/util/evsel.h | 3 + > tools/perf/util/parse-events.c | 27 +++++++++ > tools/perf/util/parse-events.h | 1 + > tools/perf/util/parse-events.l | 1 + > tools/perf/util/stat-display.c | 108 > ++++++++++++++++++++++++--------- > tools/perf/util/stat.c | 8 ++- > 10 files changed, 151 insertions(+), 34 deletions(-) > > -- > 2.7.4 >