Hi, Thierry Best Regards! Anson Huang
> -----Original Message----- > From: Thierry Reding [mailto:[email protected]] > Sent: 2019年3月18日 17:59 > To: Anson Huang <[email protected]> > Cc: [email protected]; [email protected]; [email protected]; > [email protected]; [email protected]; [email protected]; > [email protected]; [email protected]; [email protected]; > Leonard Crestez <[email protected]>; Robin Gong > <[email protected]>; [email protected]; linux- > [email protected]; [email protected]; linux-arm- > [email protected]; [email protected]; u.kleine- > [email protected]; dl-linux-imx <[email protected]> > Subject: Re: [PATCH V5 1/5] dt-bindings: pwm: Add i.MX TPM PWM binding > > On Mon, Mar 18, 2019 at 07:41:32AM +0000, Anson Huang wrote: > > Add i.MX TPM(Low Power Timer/Pulse Width Modulation Module) PWM > binding. > > > > Signed-off-by: Anson Huang <[email protected]> > > --- > > No changes. > > --- > > Documentation/devicetree/bindings/pwm/imx-tpm-pwm.txt | 19 > > +++++++++++++++++++ > > 1 file changed, 19 insertions(+) > > create mode 100644 > > Documentation/devicetree/bindings/pwm/imx-tpm-pwm.txt > > > > diff --git a/Documentation/devicetree/bindings/pwm/imx-tpm-pwm.txt > > b/Documentation/devicetree/bindings/pwm/imx-tpm-pwm.txt > > new file mode 100644 > > index 0000000..d47b8fb > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/pwm/imx-tpm-pwm.txt > > @@ -0,0 +1,19 @@ > > +Freescale i.MX TPM PWM controller > > + > > +Required properties: > > +- compatible : Should be "fsl,imx-tpm-pwm". > > Should this perhaps only be "fsl,imx-tpm"? Sounds to me like this is a > hardware block called "TPM" that can be used as a PWM. The compatible > string should describe the hardware block, not the mode in which it is used. OK, will fix it. > > > +- reg: Physical base address and length of the controller's registers. > > +- #pwm-cells: Should be 2. See pwm.txt in this directory for a description > of the cells format. > > +- clocks : The clock provided by the SoC to drive the PWM. > > +- interrupts: The interrupt for the pwm controller. > > pwm -> PWM OK. Thanks, Anson > > Thierry
