On Sat 2019-03-16 00:59:24, Yangtao Li wrote: > This patch set introduces some functions and macros that help reduce > code duplication. > > Yangtao Li (4): > PM / core: Introduce dpm_async_fn() helper > PM / core: Introduce DEVICE_SUSPEND_FUNC() helper macro > PM / core: Introduce ASYNC_RESUME_FUNC() helper macro > PM / core: Introduce ASYNC_SUSPEND_FUNC() helper macro > > drivers/base/power/main.c | 182 ++++++++++++-------------------------- > 1 file changed, 59 insertions(+), 123 deletions(-)
I'm not a big fan. Yes, you got line count down. But no, I do not think "beauty" of the macros makes it worth it. Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
signature.asc
Description: Digital signature