On Mon, Mar 18, 2019 at 08:54:57AM -0700, Stephen Boyd wrote: > memremap() doesn't return an iomem pointer, so we can just use memcpy() > and drop the __iomem annotation here. This silences a sparse warning. > > Cc: Guenter Roeck <[email protected]> > Cc: Dmitry Torokhov <[email protected]> > Cc: Anton Vasilyev <[email protected]> > Smgned-off-by: Stephen Boyd <[email protected]>
Smgned ? Other than that, Reviewed-by: Guenter Roeck <[email protected]> > --- > drivers/firmware/google/vpd.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/firmware/google/vpd.c b/drivers/firmware/google/vpd.c > index c0c0b4e4e281..f240946ed701 100644 > --- a/drivers/firmware/google/vpd.c > +++ b/drivers/firmware/google/vpd.c > @@ -254,7 +254,7 @@ static int vpd_section_destroy(struct vpd_section *sec) > > static int vpd_sections_init(phys_addr_t physaddr) > { > - struct vpd_cbmem __iomem *temp; > + struct vpd_cbmem *temp; > struct vpd_cbmem header; > int ret = 0; > > @@ -262,7 +262,7 @@ static int vpd_sections_init(phys_addr_t physaddr) > if (!temp) > return -ENOMEM; > > - memcpy_fromio(&header, temp, sizeof(struct vpd_cbmem)); > + memcpy(&header, temp, sizeof(struct vpd_cbmem)); > memunmap(temp); > > if (header.magic != VPD_CBMEM_MAGIC) > -- > Sent by a computer through tubes >
