On Wed, Mar 20, 2019 at 4:38 PM Benjamin Tissoires <benjamin.tissoi...@redhat.com> wrote: > On Wed, Mar 20, 2019 at 2:28 PM <hotwater...@tutanota.com> wrote:
> > Patch is created by help of ELANTECH and RedHat guys (Hans De Goede > > <hdego...@redhat.com>, Benjamin Tissoires <btiss...@redhat.com>, Andy > > Shevchenko <andy.shevche...@gmail.com>) and me (Vladislav Dalechyn > > <hotwater...@tutanota.com>. > > Don't take it wrong, but that's not how we give credit in a patch. > In your case, if you do not have any Elantech engineer who agreed to > sign off the patch, you can definitively mention them this way. > But the other guys (Hans, Andy and myself) are well known kernel > developers in the input and HID subsystems, so we usually take the > fame by adding our Reviewed-by or Signed-off-by tag at the end of the > commit message. (Also note that Andy is working for Intel ;-P ) > > If you feel that these persons have an equal participation in the > creation of the patch, you should ask for their Signed-off-by in the > patch. My gut feelings tell me they would gladly give a Reviewed-by > because they helped you on the patch, but they are not the "author", > so the Signed-off-by should be you only. Just in case, we have Co-developed-by: tag and for my opinion Hans' name should go under this category. -- With Best Regards, Andy Shevchenko
