On Fri, Mar 22, 2019 at 7:03 PM Christoph Hellwig <h...@infradead.org> wrote: > > > > > - /* Compute satp for kernel page tables, but don't load it yet */ > > + /* Compute satp for kernel page directory, but don't load it yet */ > > > > /* > > - * Load trampoline page directory, which will cause us to trap to > > + * Load kernel page directory, which will cause us to trap to > > * stvec if VA != PA, or simply fall through if VA == PA > > */ > > If we want to nitpick comments I think this should take about the > page table root or something like that.
Okay, I will update comments. > > Otherwise the idea looks good, but I really think we should do this > before all the changes to the setup_vm code. Sure, I will move it before setup_vm code so that setup_vm code is further simplified. Regards, Anup
