On Fri, Aug 10, Alasdair G Kergon wrote: > On Fri, Aug 10, 2007 at 10:02:09PM +0200, Jan Blunck wrote: > > Sector size on Linux is always 512 bytes. Don't even try to give the > > impression this is changeable. > > If that's what worries you, add a comment next to the definition, > perhaps?
That and that the code just looks more like the rest of the block layer code. Only a few users (UFS, MSDOS, HFS, IDE) use a predefined SECTOR_{SHIFT,SIZE}. > It's there so you can easily locate all the places within dm that > perform these conversions by using a simple search. Searching for '9' > wouldn't be as easy. (I don't know about other people, but I find the > code easier to read the way it is.) Hmm, so I guess this is more about dis/like of how the code looks. Maybe we should define a global SECTOR_{SIZE,SHIFT} into blkdev.h. Regards, Jan -- Jan Blunck <[EMAIL PROTECTED]> - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/