Hi Rob,

        Thanks for the response.
Please find my response inline.

> -----Original Message-----
> From: Rob Herring [mailto:[email protected]]
> Sent: Tuesday, March 26, 2019 12:49 AM
> To: Nava kishore Manne <[email protected]>
> Cc: [email protected]; [email protected]; [email protected]; Michal Simek
> <[email protected]>; Rajan Vaja <[email protected]>; Jolly Shah
> <[email protected]>; [email protected]; [email protected];
> [email protected]; [email protected];
> [email protected]
> Subject: Re: [PATCH v4 6/6] dt-bindings: fpga: Add bindings for ZynqMP fpga
> driver
> 
> On Thu, Mar 14, 2019 at 07:31:22PM +0530, Nava kishore Manne wrote:
> > Add documentation to describe Xilinx ZynqMP fpga driver bindings.
> >
> > Signed-off-by: Nava kishore Manne <[email protected]>
> > ---
> > Changes for v4:
> >             -Modified binding description as suggested by Moritz Fischer.
> > Changes for v3:
> >                 -Removed PCAP as a child node to the FW and Created
> >              an independent node since PCAP driver is a consumer
> >              not a provider.
> 
> Huh?
> 
> It was the fpga-regions that I suggested should perhaps be at the top-level. 
> As
> long as pcap is a function exposed by the firmware it should be a child of it.
> 
Thanks for providing the clarification. Will address the above comments in the 
next version.

Regards,
Navakishore.

Reply via email to