On Tue, 26 Mar 2019 17:43:21 +0200 Tzvetomir Stoyanov <tstoya...@vmware.com> wrote:
> Rename some traceevent APIs for consistency: > > tep_pid_is_registered() to tep_is_pid_registered() > tep_file_bigendian() to tep_is_file_bigendian() > to make the names and return values consistent with other tep_is_... APIs > > tep_data_lat_fmt() to tep_data_latency_format() > to make the name more descriptive > > tep_host_bigendian() to tep_is_bigendian() > tep_set_host_bigendian() to tep_set_local_bigendian() > tep_is_host_bigendian() to tep_is_local_bigendian() > "host" can be confused with VMs, and "local" is about the local > machine. All tep_is_..._bigendian(struct tep_handle *tep) APIs return > the saved data in the tep handle, while tep_is_bigendian() returns > the running machine's endianness. > > All tep_is_... functions are modified to return bool value, instead of int. Much nicer ;-) > > Signed-off-by: Tzvetomir Stoyanov <tstoya...@vmware.com> > --- > tools/lib/traceevent/event-parse-api.c | 44 +++++++++++++------------- > tools/lib/traceevent/event-parse.c | 26 +++++++-------- > tools/lib/traceevent/event-parse.h | 16 +++++----- > tools/lib/traceevent/plugin_kvm.c | 4 +-- > tools/perf/util/trace-event-read.c | 2 +- > tools/perf/util/trace-event.c | 4 +-- > 6 files changed, 48 insertions(+), 48 deletions(-) > > diff --git a/tools/lib/traceevent/event-parse-api.c > b/tools/lib/traceevent/event-parse-api.c > index 2ac8b44854ce..46670bb87051 100644 > --- a/tools/lib/traceevent/event-parse-api.c > +++ b/tools/lib/traceevent/event-parse-api.c > @@ -88,7 +88,7 @@ void tep_clear_flag(struct tep_handle *tep, enum tep_flag > flag) > bool tep_test_flag(struct tep_handle *tep, enum tep_flag flag) > { > if (tep) > - return (tep->flags & flag); > + return !!(tep->flags & flag); This isn't needed. The fact hat this returns "bool", the compiler will handle thins the same regardless. > return false; > } > > @@ -306,14 +306,14 @@ void tep_set_host_bigendian(struct tep_handle *pevent, > enum tep_endian endian) > * tep_is_latency_format - get if the latency output format is configured > * @pevent: a handle to the tep_handle > * > - * This gets if the latency output format is configured > - * If @pevent is NULL, 0 is returned. > + * This returns true if the latency output format is configured > + * If @pevent is NULL, false is returned. > */ > -int tep_is_latency_format(struct tep_handle *pevent) > +bool tep_is_latency_format(struct tep_handle *pevent) > { > if (pevent) > - return pevent->latency_format; > - return 0; > + return !!(pevent->latency_format); Same here. > + return false; > } > > /** The rest looks good. -- Steve