On Wed, Mar 27, 2019 at 02:02:39PM +0900, William Breathitt Gray wrote: > Replace verbose implementation in set_multiple callback with > for_each_set_clump8 macro to simplify code and improve clarity.
> + for_each_set_clump8(offset, bankmask, mask, chip->registers * 8) { > + bank = (chip->registers - 1) - (offset / 8); Excessive parens, but it's minor. > + bitmask = bitmap_get_value8(bits, offset) & bankmask; > > chip->buffer[bank] &= ~bankmask; > + chip->buffer[bank] |= bitmask; > } -- With Best Regards, Andy Shevchenko