On 3/30/2019 8:01 AM, nixiaoming wrote:
In the function divider_recalc_rate() The judgment of the return value of
_get_div() indicates that the return value of _get_div() may be 0.
s/may be/can be
In order to avoid the divide-by-zero error, add check the return values.
s/add check the/add check for
of _get_div() in the divider_ro_round_rate_parent()
Signed-off-by: nixiaoming <nixiaom...@huawei.com>
Please fix the commit text.
Reviewed-by: Mukesh Ojha <mo...@codeaurora.org>
Cheers,
-Mukesh
---
drivers/clk/clk-divider.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/clk/clk-divider.c b/drivers/clk/clk-divider.c
index e5a1726..f4bf7a4 100644
--- a/drivers/clk/clk-divider.c
+++ b/drivers/clk/clk-divider.c
@@ -347,6 +347,9 @@ long divider_ro_round_rate_parent(struct clk_hw *hw, struct
clk_hw *parent,
int div;
div = _get_div(table, val, flags, width);
+ /* avoid divide-by-zero */
+ if (!div)
+ return -EINVAL;
/* Even a read-only clock can propagate a rate change */
if (clk_hw_get_flags(hw) & CLK_SET_RATE_PARENT) {
