On Sun, Mar 31, 2019 at 09:28:03PM +0300, Andrey Abramov wrote: > This is the logical continuation of the "lib/sort & lib/list_sort: > faster and smaller" series by George Spelvin (added to linux-next > recently). > > Since Spectre mitigations have made indirect function calls more > expensive, and the previous patch series implements the default > simple byte copies without them, an "optimized" custom swap > function is now a waste of time as well as code. > > Patches 1 to 4 replace trivial swap functions with the built-in > (which is now much faster) and are grouped by subsystem. > Being pure code deletion patches, they are sure to bring joy to > Linus's heart. > > Having reviewed all call sites, only three non-trivial swap > functions remain: arch/x86/kernel/unwind_orc.c, > kernel/jump_label.c and lib/extable.c. > > Patch #5 takes the opportunity to clean up a long-standing > interface wart: the swap function's size parameter was an int, > which doesn't match the size_t element size passed to sort() > function itself. So change it to size_t. > > v1->v2: Only commit messages have changed to better explain > the purpose of commits. (Thanks to George Spelvin and Greg KH)
Thanks for an update. Hint: scripts/get_maintainer.pl --git --git-min-percent=67 ... (Note 67% magic value) > > Andrey Abramov (5): > arch/arc: unwind.c: replace swap function with built-in one > powerpc: module_[32|64].c: replace swap function with built-in one > ocfs2: dir,refcounttree,xattr: replace swap functions with built-in > one > ubifs: find.c: replace swap function with built-in one > Lib: sort.h: replace int size with size_t size in the swap function > > arch/arc/kernel/unwind.c | 20 ++------------------ > arch/powerpc/kernel/module_32.c | 17 +---------------- > arch/powerpc/kernel/module_64.c | 17 +---------------- > arch/x86/kernel/unwind_orc.c | 2 +- > fs/ocfs2/dir.c | 13 +------------ > fs/ocfs2/refcounttree.c | 13 +++---------- > fs/ocfs2/xattr.c | 15 +++------------ > fs/ubifs/find.c | 9 +-------- > include/linux/sort.h | 2 +- > kernel/jump_label.c | 2 +- > lib/extable.c | 2 +- > lib/sort.c | 6 +++--- > 12 files changed, 19 insertions(+), 99 deletions(-) > > -- > 2.21.0 > > -- With Best Regards, Andy Shevchenko
