On 2/23/2019 6:50 PM, Julia Lawall wrote:
Add an of_node_put when a tested device node is not available. The semantic patch that fixes this problem is as follows (http://coccinelle.lip6.fr): // <smpl> @@ identifier f; local idexpression e; expression x; @@ e = f(...); ... when != of_node_put(e) when != x = e when != e = x when any if (<+...of_device_is_available(e)...+>) { ... when != of_node_put(e) ( return e; | + of_node_put(e); return ...; ) } // </smpl> Fixes: 53d2a715c2403 ("phy: Add Tegra XUSB pad controller support") Signed-off-by: Julia Lawall <julia.law...@lip6.fr>
Reviewed-by: Mukesh Ojha <mo...@codeaurora.org> Cheers, -Mukesh
--- drivers/phy/tegra/xusb.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff -u -p a/drivers/phy/tegra/xusb.c b/drivers/phy/tegra/xusb.c --- a/drivers/phy/tegra/xusb.c +++ b/drivers/phy/tegra/xusb.c @@ -260,8 +260,10 @@ tegra_xusb_pad_create(struct tegra_xusb_ int err;np = tegra_xusb_find_pad_node(padctl, soc->name);- if (!np || !of_device_is_available(np)) + if (!np || !of_device_is_available(np)) { + of_node_put(np); return NULL; + }pad = soc->ops->probe(padctl, soc, np);if (IS_ERR(pad)) {
