On Mon, 13 Aug 2007 22:05:10 +0200 Adrian Bunk wrote: > On Mon, Aug 13, 2007 at 03:13:30PM -0400, Robert P. J. Day wrote: > > On Mon, 13 Aug 2007, Adrian Bunk wrote: > > > > > On Mon, Aug 13, 2007 at 11:38:09AM -0700, Randy Dunlap wrote: > > > > From: Randy Dunlap <[EMAIL PROTECTED]> > > > > > > > > Add kconfig-language docs for mainmenu, def_bool[ean], > > > > and def_tristate. > > > > > > > > Signed-off-by: Randy Dunlap <[EMAIL PROTECTED]> > > > > Signed-off-by: Vincent Legoll <[EMAIL PROTECTED]> > > > > --- > > > > Documentation/kbuild/kconfig-language.txt | 12 ++++++++++++ > > > > 1 file changed, 12 insertions(+) > > > > > > > > --- linux-2.6.23-rc3.orig/Documentation/kbuild/kconfig-language.txt > > > > +++ linux-2.6.23-rc3/Documentation/kbuild/kconfig-language.txt > > > > @@ -77,6 +77,11 @@ applicable everywhere (see syntax). > > > > Optionally, dependencies only for this default value can be added > > > > with > > > > "if". > > > > > > > > +- type definition + default value: > > > > + "def_bool"/"def_boolean"/"def_tristate" <expr> ["if" <expr>] > > > >... > > > > > > Should the redundant and unused def_boolean be documented or removed? > > > > > > I'd prefer the latter. > > > > me too. and, as i've suggested before, it would also be cleaner to > > remove the redundant "requires" and almost redundant "depends" from > > Kconfig files, and standardize exclusively on "depends on". > >... > > Patch below. > > > rday > > cu > Adrian > > > <-- snip --> > > > This patch removes the following redundant and never or rarely used > kconfig syntax: > - "def_boolean" (same as "def_bool") > - "requires" (same as "depends on") > - "depends" (same as "depends on") > > Most of the size of this patch comes from regenerating generated files.
Looks OK to me. Missing S-O-B line... > --- > > arch/blackfin/Kconfig | 2 > arch/powerpc/Kconfig.debug | 6 > arch/powerpc/platforms/Kconfig | 2 > drivers/input/misc/Kconfig | 2 > drivers/leds/Kconfig | 2 > drivers/telephony/Kconfig | 2 > net/wireless/Kconfig | 2 > scripts/kconfig/lex.zconf.c_shipped | 4 > scripts/kconfig/zconf.gperf | 2 > scripts/kconfig/zconf.hash.c_shipped | 223 ++-- > scripts/kconfig/zconf.tab.c_shipped | 1406 ++++++++++++++------------- > scripts/kconfig/zconf.y | 11 > 12 files changed, 889 insertions(+), 775 deletions(-) --- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code *** - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
