On Wed, Apr 3, 2019 at 2:02 AM Guenter Roeck <[email protected]> wrote:

> Use devm_platform_ioremap_resource to reduce source code size,
> improve readability, and reduce the likelyhood of bugs.
>
> The conversion was done automatically with coccinelle using the
> following semantic patch.
>
> @r@
> identifier res, pdev;
> expression a;
> expression index;
> expression e;
> @@
>
> <+...
> - res = platform_get_resource(pdev, IORESOURCE_MEM, index);
> - a = devm_ioremap_resource(e, res);
> + a = devm_platform_ioremap_resource(pdev, index);
> ...+>
>
> @depends on r@
> identifier r.res;
> @@
> - struct resource *res;
>   ... when != res
>
> @@
> identifier res, pdev;
> expression index;
> expression a;
> @@
> - struct resource *res = platform_get_resource(pdev, IORESOURCE_MEM, index);
> - a = devm_ioremap_resource(&pdev->dev, res);
> + a = devm_platform_ioremap_resource(pdev, index);
>
> Cc: Joel Stanley <[email protected]>
> Cc: Nicolas Ferre <[email protected]>
> Cc: Alexandre Belloni <[email protected]>
> Cc: Florian Fainelli <[email protected]>
> Cc: Linus Walleij <[email protected]>
> Cc: Baruch Siach <[email protected]>
> Cc: Keguang Zhang <[email protected]>
> Cc: Vladimir Zapolskiy <[email protected]>
> Cc: Kevin Hilman <[email protected]>
> Cc: Matthias Brugger <[email protected]>
> Cc: Avi Fishman <[email protected]>
> Cc: Nancy Yuen <[email protected]>
> Cc: Brendan Higgins <[email protected]>
> Cc: Wan ZongShun <[email protected]>
> Cc: Michal Simek <[email protected]>
> Cc: Sylvain Lemieux <[email protected]>
> Cc: Kukjin Kim <[email protected]>
> Cc: Barry Song <[email protected]>
> Cc: Orson Zhai <[email protected]>
> Cc: Patrice Chotard <[email protected]>
> Cc: Maxime Coquelin <[email protected]>
> Cc: Maxime Ripard <[email protected]>
> Cc: Chen-Yu Tsai <[email protected]>
> Cc: Marc Gonzalez <[email protected]>
> Cc: Thierry Reding <[email protected]>
> Cc: Shawn Guo <[email protected]>
> Signed-off-by: Guenter Roeck <[email protected]>

Nice Cocinelle work!!
Reviewed-by: Linus Walleij <[email protected]>

Yours,
Linus Walleij

Reply via email to