Re: [PATCH V2] mmc: tegra: add sdhci tegra suspend and resume

[Thierry Reding]

On Tue, Apr 02, 2019 at 10:37:21AM -0700, Sowjanya Komatineni wrote:
> This patch adds suspend and resume PM ops for tegra SDHCI.
> 
> Signed-off-by: Sowjanya Komatineni <skomatin...@nvidia.com>
> ---
>  drivers/mmc/host/sdhci-tegra.c | 56 
> +++++++++++++++++++++++++++++++++++++++++-
>  1 file changed, 55 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/mmc/host/sdhci-tegra.c b/drivers/mmc/host/sdhci-tegra.c
> index eafaaefab4a6..6c91926a012c 100644
> --- a/drivers/mmc/host/sdhci-tegra.c
> +++ b/drivers/mmc/host/sdhci-tegra.c
> @@ -1611,11 +1611,65 @@ static int sdhci_tegra_remove(struct platform_device 
> *pdev)
>       return 0;
>  }
>  
> +#ifdef CONFIG_PM_SLEEP
> +static int sdhci_tegra_suspend(struct device *dev)
> +{
> +     struct sdhci_host *host = dev_get_drvdata(dev);
> +     struct sdhci_pltfm_host *pltfm_host = sdhci_priv(host);
> +     int ret;
> +
> +     if (host->mmc->caps2 & MMC_CAP2_CQE) {
> +             ret = cqhci_suspend(host->mmc);
> +             if (ret)
> +                     return ret;
> +     }
> +
> +     ret = sdhci_suspend_host(host);
> +     if (ret)
> +             return ret;

I didn't spot this earlier, but I think we'd need cqhci_resume() here in
case of failure.

With that fixed:

Acked-by: Thierry Reding <tred...@nvidia.com>

signature.asc
Description: PGP signature