On 01/04/2019 20:18, Martin Blumenstingl wrote:
> From: Bichao Zheng <bichao.zh...@amlogic.com>
> 
> There is an abnormally low about 20ms,when setting duty repeatedly.
> Because setting the duty will disable pwm and then enable. Delete
> this operation now.
> 
> Fixes: 211ed630753d2f ("pwm: Add support for Meson PWM Controller")
> Signed-off-by: Bichao Zheng <bichao.zh...@amlogic.com>
> [ Dropped code instead of hiding it behind a comment ]
> Signed-off-by: Martin Blumenstingl <martin.blumensti...@googlemail.com>
> ---
>  drivers/pwm/pwm-meson.c | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/drivers/pwm/pwm-meson.c b/drivers/pwm/pwm-meson.c
> index 4b708c1fcb1d..e247ab632530 100644
> --- a/drivers/pwm/pwm-meson.c
> +++ b/drivers/pwm/pwm-meson.c
> @@ -325,11 +325,6 @@ static int meson_pwm_apply(struct pwm_chip *chip, struct 
> pwm_device *pwm,
>       if (state->period != channel->state.period ||
>           state->duty_cycle != channel->state.duty_cycle ||
>           state->polarity != channel->state.polarity) {
> -             if (channel->state.enabled) {
> -                     meson_pwm_disable(meson, pwm->hwpwm);
> -                     channel->state.enabled = false;
> -             }
> -
>               if (state->polarity != channel->state.polarity) {
>                       if (state->polarity == PWM_POLARITY_NORMAL)
>                               meson->inverter_mask |= BIT(pwm->hwpwm);
> 

Reviewed-by: Neil Armstrong <narmstr...@baylibre.com>

Reply via email to