> @@ -210,7 +210,7 @@  static int __init maple_cpufreq_init(void)
>        */
>       valp = of_get_property(cpunode, "clock-frequency", NULL);
>       if (!valp)
> -             return -ENODEV;
> +             goto bail_noprops;
>       max_freq = (*valp)/1000;
>       maple_cpu_freqs[0].frequency = max_freq;
>       maple_cpu_freqs[1].frequency = max_freq/2;

* How do you think about use the jump label “put_node” instead?

* Would you like to reduce a bit of duplicate source code at the end
  of this function?
  
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/drivers/cpufreq/maple-cpufreq.c?id=bf97b82f37c6d90e16de001d0659644c57fa490d#n232

Regards,
Markus

Reply via email to