Hi Will, On Wed, Apr 3, 2019 at 9:45 PM Will Deacon <will.dea...@arm.com> wrote: > > Hi Masahiro, > > On Wed, Apr 03, 2019 at 05:48:22PM +0900, Masahiro Yamada wrote: > > - $(call if_changed,...) must have FORCE as a prerequisite > > > > - vdso.lds is a generated file, so it should be prefixed with > > $(obj)/ instead of $(src)/. > > Hmm, this sounds quite alarming! How come out of tree builds seem to work > ok without this patch?
No, I do not mean like that. This is just cosmetic (at least for now). Kbuild conventionally use both $(obj) and $(src), but they are the same in most places. If you see the top of scripts/Makefile.build, $(src) is the same as $(obj). I fixed this x86 in commit 1742ed2088. VDSO Makefiles are copied from arch to arch. -- Best Regards Masahiro Yamada