On Mon, Apr 1, 2019 at 11:02 PM Mark Brown <broo...@kernel.org> wrote: > regmap-irq should support active high/low, and if it doesn't it can't be > a unique thing that only this device wants to implement so the common > code should be improved.
The rt5677 driver needs its own irq regardless for hotword detection. If we implemented this in regmap-irq, we wouldn't be able to use it. > This looks unrelated to the polarity of the interupt? Yes this is separate. If a plug/unplug happens after regmap_read and before regmap_write, it will not be registered, so we loop to make sure that it's caught in a later iteration. I can clarify this in the patch notes.
