On Sat, Mar 30, 2019 at 12:17:12AM +0000, Colin King wrote: > From: Colin Ian King <[email protected]> > > Currently the kfree of output.pointer can be potentially freeing > an uninitalized pointer in the case where out_data is NULL. Fix this > by reworking the case where out_data is not-null to perform the > ACPI status check and also the kfree of outpoint.pointer in one block > and hence ensuring the pointer is only freed when it has been used. > > Also replace the if (ptr != NULL) idiom with just if (ptr). > > Fixes: ff0e9f26288d ("platform/x86: alienware-wmi: Correct a memory leak") > Signed-off-by: Colin Ian King <[email protected]>
Thanks for the catch Colin, queued for testing. Did you trigger this error or detect it via review or static analysis? -- Darren Hart VMware Open Source Technology Center
