Re: [PATCH] extcon: axp288: Fix build err without CONFIG_ACPI

[Mukesh Ojha]

On 4/4/2019 4:12 PM, Yue Haibing wrote:

From: YueHaibing <yuehaib...@huawei.com>

When building CONFIG_ACPI is not set
gcc warn this:

drivers/extcon/extcon-axp288.c: In function 'axp288_extcon_probe':
drivers/extcon/extcon-axp288.c:363:20: error: dereferencing pointer to 
incomplete type
     put_device(&adev->dev);

Reported-by: Hulk Robot <hul...@huawei.com>
Fixes: 0cf064db948a ("extcon: axp288: Convert to use 
acpi_dev_get_first_match_dev()")
Signed-off-by: YueHaibing <yuehaib...@huawei.com>

Looks fine to me.
Reviewed-by: Mukesh Ojha <mo...@codeaurora.org>

Cheers,
-Mukesh

---
  drivers/extcon/extcon-axp288.c | 8 +++++---
  1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/drivers/extcon/extcon-axp288.c b/drivers/extcon/extcon-axp288.c
index 50f9402..ed8ac3f 100644
--- a/drivers/extcon/extcon-axp288.c
+++ b/drivers/extcon/extcon-axp288.c
@@ -333,7 +333,6 @@ static int axp288_extcon_probe(struct platform_device *pdev)
        struct axp288_extcon_info *info;
        struct axp20x_dev *axp20x = dev_get_drvdata(pdev->dev.parent);
        struct device *dev = &pdev->dev;
-       struct acpi_device *adev;
        int ret, i, pirq;

info = devm_kzalloc(&pdev->dev, sizeof(*info), GFP_KERNEL);

@@ -357,6 +356,8 @@ static int axp288_extcon_probe(struct platform_device *pdev)
                if (ret)
                        return ret;

+#ifdef CONFIG_ACPI

+               struct acpi_device *adev;
                adev = acpi_dev_get_first_match_dev("INT3496", NULL, -1);
                if (adev) {
                        info->id_extcon = 
extcon_get_extcon_dev(acpi_dev_name(adev));
@@ -365,9 +366,10 @@ static int axp288_extcon_probe(struct platform_device 
*pdev)
                                return -EPROBE_DEFER;

dev_info(dev, "controlling USB role\n");

-               } else {
-                       dev_info(dev, "controlling USB role based on Vbus 
presence\n");
                }
+#else
+               dev_info(dev, "controlling USB role based on Vbus presence\n");
+#endif
        }

info->vbus_attach = axp288_get_vbus_attach(info);