Re: [PATCH] mm/gup.c: fix the wrong comments

Thu, 04 Apr 2019 05:33:14 -0700 


> On Apr 4, 2019, at 1:23 AM, Huang Shijie <[email protected]> wrote:
> 
> 
> + * This function is different from the get_user_pages_unlocked():
> + *      The @pages may has different page order with the result
> + *      got by get_user_pages_unlocked().
> + *

I suggest a slight rewrite of the comment, something like:

* Note this routine may fill the pages array with entries in a
* different order than get_user_pages_unlocked(), which may cause
* issues for callers expecting the routines to be equivalent.






















					Reply via email to