Thanks for the review Joe,@@ -458,13 +458,13 @@ static int sdw_assign_device_num(struct sdw_slave *slave)
Yes indeed, I just fixed that tools reported, but that is a miss. Will fix with a v2 (hopefully with other comments).mutex_unlock(&slave->bus->bus_lock); if (dev_num < 0) { dev_err(slave->bus->dev, "Get dev_num failed: %d", - dev_num); + dev_num);You could also add the missing terminating '\n' to these formats like: dev_err(slave->bus->dev, "Get dev_num failed: %d\n",
-Pierre