Hi,
On 07-04-19 22:58, Robert R. Howell wrote:
On 4/3/19 2:54 AM, Hans de Goede wrote:
Hi,
On 03-04-19 07:43, Kai-Heng Feng wrote:
i2c-designware-platdrv fails to work after the system restored from
hibernation:
[ 272.775692] i2c_designware 80860F41:00: Unknown Synopsys component type:
0xffffffff
Commit 48402cee6889 ("ACPI / LPSS: Resume BYT/CHT I2C controllers from
resume_noirq") makes acpi_lpss_{suspend_late,resume_early}() bail early
on BYT/CHT as resume_from_noirq is set. This means dw_i2c_plat_resume()
doesn't gets called by acpi_lpss_resume_early(), and this causes the
issue.
...
The ordering problem fixed by commit 48402cee6889 can hit hibernate too,
so I think it would be better to do this instead to fix this problem:
diff --git a/drivers/acpi/acpi_lpss.c b/drivers/acpi/acpi_lpss.c
index 1e2a10a06b9d..cf768608437e 100644
...
If people affected by the problem can give my version of the fix a test,
then that would be great.
Regards,
Hans
I did try applying your (Hans') patch to a 5.0.0 and a 5.1-rc3 kernel, instead
of what I had
been doing previously, which was reverting commit 02e45646d53b. I tested it on
an ASUS T100TA
and unfortunately with both kernels after resume from hibernation I still get
errors like those
listed below, and sound no longer works. I also tried applying the patch from
Kai-Heng Feng
(instead of Hans' patch or my revert) on both kernels and again in both cases I
get these same errors.
In contrast, on the 5.0.0 kernel when I revert 02e45646d53b, the problem is
fixed. Because
of changes in adjacent code in 5.1-rc3, I haven't yet found a way to merge the
new code
and the 02e45646d53b revert without causing worse problems. But that's probably
because
I don't really understand the details of that code.
[ 120.690428] i2c_designware 80860F41:01: timeout waiting for bus ready
[ 120.690442] rt5640 i2c-10EC5640:00: Failed to write 13d = 3600: -110
[ 120.712860] i2c_designware 80860F41:01: timeout waiting for bus ready
[ 120.737389] i2c_designware 80860F41:01: timeout waiting for bus ready
[ 120.759657] i2c_designware 80860F41:01: timeout waiting for bus ready
[ 120.781797] i2c_designware 80860F41:01: timeout waiting for bus ready
[ 120.804153] i2c_designware 80860F41:01: timeout waiting for bus ready
[ 120.826467] i2c_designware 80860F41:01: timeout waiting for bus ready
[ 121.965886] i2c_designware 80860F41:01: timeout in disabling adapter
.....
[ 132.782634] i2c_designware 80860F41:01: controller timed out
[ 133.806538] i2c_designware 80860F41:01: controller timed out
[ 134.830991] i2c_designware 80860F41:01: controller timed out
[ 135.855183] i2c_designware 80860F41:01: controller timed out
Let me know if I can do any other testing to help.
Hmm, interesting so you have hibernation working on a T100TA
(with 5.0 + 02e45646d53b reverted), right ?
I must admit I never try hibernation myself, in experience it tends to
have more issues then regular suspend/resume and there are already enough
other issues to worry about on Bay and Cherry Trail based devices.
But if it works on the T100TA and 02e45646d53b broke it then I will
try to fix this, I've a T100TA myself. Currently my T100TA is at my
local hackerspace, so I will not have access to it until coming Friday.
Regards,
Hans
