Re: [PATCH v1] init: Do not select DEBUG_KERNEL by default

[Sinan Kaya]

On 4/10/2019 6:28 PM, Kees Cook wrote:

diff --git a/init/Kconfig b/init/Kconfig
index c9386a365eea..7ce4a60ab3e9 100644
--- a/init/Kconfig
+++ b/init/Kconfig
@@ -1188,8 +1188,6 @@ config BPF

  menuconfig EXPERT
         bool "Configure standard kernel features (expert users)"
-       # Unhide debug options, to make the on-by-default options visible
-       select DEBUG_KERNEL
         help
           This option allows certain base kernel options and settings
            to be disabled or tweaked. This is for specialized
diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
index d4df5b24d75e..6a9bc118b64a 100644
--- a/lib/Kconfig.debug
+++ b/lib/Kconfig.debug
@@ -433,6 +433,7 @@ config MAGIC_SYSRQ_SERIAL

  config DEBUG_KERNEL
         bool "Kernel debugging"
+       default EXPERT
         help
           Say Y here if you are developing drivers or trying to debug and
           identify kernel problems.

Got it. Thanks. I'll test and respin v2.