Hi Daniel,
> -----Original Message-----
> From: Daniel Lezcano <daniel.lezc...@linaro.org>
> Sent: 2019年4月4日 10:35
> To: Andy Tang <andy.t...@nxp.com>; shawn...@kernel.org
> Cc: Leo Li <leoyang...@nxp.com>; robh...@kernel.org; mark.rutl...@arm.com;
> linux-arm-ker...@lists.infradead.org; devicet...@vger.kernel.org;
> linux-kernel@vger.kernel.org; linux...@vger.kernel.org; rui.zh...@intel.com;
> edubez...@gmail.com
> Subject: Re: [PATCH v4] arm64: dts: ls1088a: add one more thermal zone node
> > + <&cpu1 THERMAL_NO_LIMIT
> THERMAL_NO_LIMIT>,
> > + <&cpu2 THERMAL_NO_LIMIT
> THERMAL_NO_LIMIT>,
> > + <&cpu3 THERMAL_NO_LIMIT
> THERMAL_NO_LIMIT>,
> > + <&cpu4 THERMAL_NO_LIMIT
> THERMAL_NO_LIMIT>,
> > + <&cpu5 THERMAL_NO_LIMIT
> THERMAL_NO_LIMIT>,
> > + <&cpu6 THERMAL_NO_LIMIT
> THERMAL_NO_LIMIT>,
> > + <&cpu7 THERMAL_NO_LIMIT
> THERMAL_NO_LIMIT>;
> > + };
>
> Does it make sense to assign the same cooling devices to two different thermal
> zones running different instances of governor ?
Even though I didn't find any error when test, I do think it is inappropriate.
BR,
Andy
>
> > + };
> > + };
> > +
> > + platform-thermal {
> > + polling-delay-passive = <1000>;
> > + polling-delay = <5000>;
> > + thermal-sensors = <&tmu 1>;
> > +
> > + trips {
> > + platform_alert: platform-alert {
> > + temperature = <85000>;
> > + hysteresis = <2000>;
> > + type = "passive";
> > + };
> > +
> > + platform_crit: platform-crit {
> > + temperature = <95000>;
> > + hysteresis = <2000>;
> > + type = "critical";
> > + };
> > + };
> > +
> > + cooling-maps {
> > + map0 {
> > + trip = <&platform_alert>;
> > cooling-device =
> > <&cpu0 THERMAL_NO_LIMIT
> THERMAL_NO_LIMIT>,
> > <&cpu1 THERMAL_NO_LIMIT
> THERMAL_NO_LIMIT>,
> >
>
>
> --
>
> <https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.lin
> aro.org%2F&data=02%7C01%7Candy.tang%40nxp.com%7Ce1b704832ea34
> 6ae738408d6b8a6283f%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C
> 636899421110441574&sdata=C7mrUztObkHMZyqEJg53h99SdIweJSeKhi8l
> %2BQpUQhA%3D&reserved=0> Linaro.org │ Open source software for
> ARM SoCs
>
> Follow Linaro:
> <https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.fac
> ebook.com%2Fpages%2FLinaro&data=02%7C01%7Candy.tang%40nxp.com
> %7Ce1b704832ea346ae738408d6b8a6283f%7C686ea1d3bc2b4c6fa92cd99c5c30
> 1635%7C0%7C0%7C636899421110441574&sdata=Pxj%2Blfc%2FC1KiQBD0
> kzTjQGT2AgjCbYlcXhnscWTb6pw%3D&reserved=0> Facebook |
> <https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Ftwitter.c
> om%2F%23!%2Flinaroorg&data=02%7C01%7Candy.tang%40nxp.com%7Ce
> 1b704832ea346ae738408d6b8a6283f%7C686ea1d3bc2b4c6fa92cd99c5c301635
> %7C0%7C0%7C636899421110441574&sdata=YJQRgMTwcG%2B3H1g%2FX
> h3zaw%2BXy8OdlstL5AH4R0eXmN8%3D&reserved=0> Twitter |
> <https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.lin
> aro.org%2Flinaro-blog%2F&data=02%7C01%7Candy.tang%40nxp.com%7C
> e1b704832ea346ae738408d6b8a6283f%7C686ea1d3bc2b4c6fa92cd99c5c30163
> 5%7C0%7C0%7C636899421110441574&sdata=rlkO6mkHgdam8K2RTwsOf
> 8ExPF2KRy%2FrMwwyshRBKAg%3D&reserved=0> Blog
