> Right now we are using find_memory_block() to get the node id for the
> pfn range to online. We are missing to drop a reference to the memory
> block device. While the device still gets unregistered via
> device_unregister(), resulting in no user visible problem, the device is
> never released via device_release(), resulting in a memory leak. Fix
> that by properly using a put_device().
>
> Fixes: d0dc12e86b31 ("mm/memory_hotplug: optimize memory hotplug")
> Cc: Andrew Morton <a...@linux-foundation.org>
> Cc: Oscar Salvador <osalva...@suse.de>
> Cc: Michal Hocko <mho...@suse.com>
> Cc: David Hildenbrand <da...@redhat.com>
> Cc: Pavel Tatashin <pasha.tatas...@soleen.com>
> Cc: Wei Yang <richard.weiy...@gmail.com>
> Cc: Qian Cai <c...@lca.pw>
> Cc: Arun KS <aru...@codeaurora.org>
> Cc: Mathieu Malaterre <ma...@debian.org>
> Reviewed-by: Oscar Salvador <osalva...@suse.de>
> Reviewed-by: Wei Yang <richard.weiy...@gmail.com>
> Acked-by: Michal Hocko <mho...@suse.com>
> Signed-off-by: David Hildenbrand <da...@redhat.com>
> ---
> mm/memory_hotplug.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c
> index 5eb4a4c7c21b..328878b6799d 100644
> --- a/mm/memory_hotplug.c
> +++ b/mm/memory_hotplug.c
> @@ -854,6 +854,7 @@ int __ref online_pages(unsigned long pfn, unsigned long
> nr_pages, int online_typ
> */
> mem = find_memory_block(__pfn_to_section(pfn));
> nid = mem->nid;
> + put_device(&mem->dev);
>
> /* associate pfn range with the zone */
> zone = move_pfn_range(online_type, nid, pfn, nr_pages);
> --
> 2.20.1
Good catch it is.
Acked-by: Pankaj Gupta <pagu...@redhat.com>
>
>
