On 04/11/2019 04:37 AM, Peter Zijlstra wrote: > > After applying: > > 1,2,5,3 > > Do we want to do something like the below? > > There is absolutely no reason anymore we need spread the implementation > over 3 files: rwsem.h rwsem.c rwsem-xadd.c. And I went insane chasing > things around. > > Note the below also includes a number of cleanups, there were still a > bunch of EXPORT_SYMBOL()s and __visible crud from back when there was > arch asm. > > And I also removed a bunch of pointless wrapper functions. > > I suspect there's more cleanups to be had, but for now this will do I > suppose. > > --- > a/kernel/locking/rwsem-xadd.c | 608 ------------------------------ > kernel/locking/Makefile | 2 > kernel/locking/rwsem.c | 831 > ++++++++++++++++++++++++++++++++++++++++-- > kernel/locking/rwsem.h | 282 -------------- > 4 files changed, 813 insertions(+), 910 deletions(-)
I am OK with that. I am just so used to working with rwsem-xadd.c that the idea of merging rwsem-xadd.c into rwsem.c didn't come to my mind. I will include that in the next version. Cheers, Longman
