On Fri, Apr 05, 2019 at 08:32:10PM +0300, Yury Norov wrote:
> Add tests for non-number character, empty regions, integer overflow.
>
> Signed-off-by: Yury Norov <[email protected]>
> Reviewed-by: Andy Shevchenko <[email protected]>
> ---
> lib/test_bitmap.c | 18 +++++++++++++++++-
> 1 file changed, 17 insertions(+), 1 deletion(-)
>
> diff --git a/lib/test_bitmap.c b/lib/test_bitmap.c
> index b06e0fd3811b..709424a788ee 100644
> --- a/lib/test_bitmap.c
> +++ b/lib/test_bitmap.c
> @@ -224,7 +224,8 @@ static const unsigned long exp[] __initconst = {
> BITMAP_FROM_U64(0xffffffff),
> BITMAP_FROM_U64(0xfffffffe),
> BITMAP_FROM_U64(0x3333333311111111ULL),
> - BITMAP_FROM_U64(0xffffffff77777777ULL)
> + BITMAP_FROM_U64(0xffffffff77777777ULL),
> + BITMAP_FROM_U64(0),
> };
>
> static const unsigned long exp2[] __initconst = {
> @@ -247,19 +248,34 @@ static const struct test_bitmap_parselist
> parselist_tests[] __initconst = {
> {0, "1-31:4/4", &exp[9 * step], 32, 0},
> {0, "0-31:1/4,32-63:2/4", &exp[10 * step], 64, 0},
> {0, "0-31:3/4,32-63:4/4", &exp[11 * step], 64, 0},
> + {0, " ,, 0-31:3/4 ,, 32-63:4/4 ,, ", &exp[11 * step], 64, 0},
>
> {0, "0-31:1/4,32-63:2/4,64-95:3/4,96-127:4/4", exp2, 128, 0},
>
> {0, "0-2047:128/256", NULL, 2048, PARSE_TIME},
>
> + {0, "", &exp[12], 8, 0},
> + {0, "\n", &exp[12], 8, 0},
> + {0, ",, ,, , , ,", &exp[12], 8, 0},
> + {0, " , ,, , , ", &exp[12], 8, 0},
> + {0, " , ,, , , \n", &exp[12], 8, 0},
> +
This results in error messages such as
test_bitmap: parselist: 17: input is ,, ,, , , ,, result is 0x0, expected
0x11111111
test_bitmap: parselist: 18: input is , ,, , , , result is 0x0, expected
0x11111111
on 32-bit systems. The above should be "&exp[12 * step]".
Guenter
> {-EINVAL, "-1", NULL, 8, 0},
> {-EINVAL, "-0", NULL, 8, 0},
> {-EINVAL, "10-1", NULL, 8, 0},
> {-EINVAL, "0-31:", NULL, 8, 0},
> {-EINVAL, "0-31:0", NULL, 8, 0},
> + {-EINVAL, "0-31:0/", NULL, 8, 0},
> {-EINVAL, "0-31:0/0", NULL, 8, 0},
> {-EINVAL, "0-31:1/0", NULL, 8, 0},
> {-EINVAL, "0-31:10/1", NULL, 8, 0},
> + {-EOVERFLOW, "0-98765432123456789:10/1", NULL, 8, 0},
> +
> + {-EINVAL, "a-31", NULL, 8, 0},
> + {-EINVAL, "0-a1", NULL, 8, 0},
> + {-EINVAL, "a-31:10/1", NULL, 8, 0},
> + {-EINVAL, "0-31:a/1", NULL, 8, 0},
> + {-EINVAL, "0-\n", NULL, 8, 0},
> };
>
> static void __init test_bitmap_parselist(void)
